RDKEMW-1014 : Add COM-RPC support to HdcpProfile plugin #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…nputoutput into topic/RDKEMW-1014
ssitar583
force-pushed
the
topic/RDKEMW-1014
branch
from
652aba8 to
b7fa382
Compare
|
b'## WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted
|
…nputoutput into topic/RDKEMW-1014
…services-inputoutput into topic/RDKEMW-1014
srikanth-vv
requested changes
Apr 17, 2025
| static HdcpProfile* _instance; | ||
| namespace Plugin { | ||
|
|
||
| class HdcpProfile : public PluginHost::IPlugin, public PluginHost::JSONRPC |
There was a problem hiding this comment.
A minor comment: The indentation doesn't look correct. Please fix this.
| _parent.Deactivated(connection); | ||
| } | ||
|
|
||
| void OnDisplayConnectionChanged(const Exchange::IHdcpProfile::HDCPStatus hdcpstatus) override |
There was a problem hiding this comment.
Can you change this parameter "hdcpstatus" to call by referece "&hdcpstatus"?
…nputoutput into topic/RDKEMW-1014
…services-inputoutput into topic/RDKEMW-1014
…nputoutput into topic/RDKEMW-1014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.